From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 03 Sep 2007 00:22:02 GMT
Subject: Re: [PATCH] gitweb: Fix file name quoting in simplified out patch detection for --cc output
Message-ID: <7vabs4oaxh.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200709022222.13865.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 8c1e02c..5d424e5 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3140,8 +3140,8 @@ sub git_patchset_body {
>  			# compact combined diff output can have some patches skipped
>  			# find which patch (using pathname of result) we are at now
>  			my $to_name;
> -			if ($patch_line =~ m!^diff --cc "?(.*)"?$!) {
> -				$to_name = $1;
> +			if ($patch_line =~ m!^diff --cc ("?.*"?)$!) {
> +				$to_name = unquote($1);
>  			}

This patch obviously makes sense, but I wonder why you use the
form m!foobar! here, instead of far simpler to read /foobar/
form?