From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 19 Sep 2007 00:55:52 GMT
Subject: Re: [PATCH 4/5] Full rework of quote_c_style and write_name_quoted.
Message-ID: <7vabrjtqw7.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20070919000757.GC4535@artemis.corp>

Pierre Habouzit <madcoder@debian.org> writes:

> On Tue, Sep 18, 2007 at 10:00:51PM +0000, Pierre Habouzit wrote:
>> +		cp = strchr(qname.buf + qname.len + 3 - max, '/');
>> +		if (cp)
>> +			cp = qname.buf + qname.len + 3 - max;
>
>   OMG, this is supposed to be if (!cp) of course...
>
>   I wonder how this passed the testsuite.

You would need a new test, I guess, before a huge rewrite.