From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 04 Jan 2008 08:26:55 GMT
Subject: Re: [BUG] git-diff-* --color oddness
Message-ID: <7vabnmm1ww.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080104081429.GA30635@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The first two lines of meta-info will be in the stock colors, but
> everything after will be in the custom colors. So we are actually
> reading the diff_ui options _during_ the diff. The culprit is
> funcname_pattern, which calls read_config_if_needed.

Yuck.  Why is funcname_pattern do ui-config stuff?  I know it
wants to get custom regexp crap, but that should belong to the
plumbing part, not Porcelain-only thing, shouldn't it?