From: Junio C Hamano Date: Mon, 18 Feb 2008 03:45:07 GMT Subject: Re: [PATCH 2/4] Export some email and pretty-printing functions Message-ID: <7vablzudvg.fsf@gitster.siamese.dyndns.org> In-Reply-To: Daniel Barkalow writes: > +void add_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb, > + const char *line, enum date_mode dmode, > + const char *encoding); Exactly the same comment about "the function name being too generic" from the last round still applies.