From: Junio C Hamano Date: Sun, 08 Jun 2008 18:53:37 GMT Subject: Re: [PATCH 1/3] Modified test-lib.sh to output stats to /tmp/git-test-results Message-ID: <7vabhvkbbi.fsf@gitster.siamese.dyndns.org> In-Reply-To: "Sverre Rabbelier" writes: > On Sun, Jun 8, 2008 at 4:42 PM, Jakub Narebski wrote: >> "Sverre Rabbelier" writes: >> >>> Because writing to the current directory is not possible, we write to /tmp/. >>> Suggestions for a better location are welcome. >> >>> + test_results_path="../test-results" >> >> Errr... it looks like you forgot to update commit message. > > Yeah, I intended to fix that when amending the original commit, but I > forgot. I thought I couldn't write to the current dir, but instead I > was writing to /t/trash, which of course gets deleted after every > test. Obviously outputting to ../test-results fixed that. Some tests may chdir around and when you hit test_done they may not be in the directory directly under t/ anymore. I'd say that such a test is ill-mannered, but we would want to protect ourselves against such mischief somehow. Also, this won't be an immediate issue, but we may want to lift the ".NOTPARALLEL" limitation in t/Makefile sometime in the future. A handful tests need to be adjusted for this change, as they currently refer their test vectors in t/tXXXX/ as ../tXXXX, and with such a change, we would run each test in "t/trash directory/t$$" where $$ is the pid, or something like that. A single "test-results" file everybody races to append would become unwieldy at that point. Something to keep in mind.