From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 17 Nov 2008 16:48:14 GMT
Subject: Re: [PATCH 3/3] git-remote: simplifying get_one_entry
Message-ID: <7vabbywb75.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1226920551-28303-3-git-send-email-crquan@gmail.com>

crquan@gmail.com writes:

> From: Cheng Renquan <crquan@gmail.com>
>
> The loop for remote->url_nr is really useless, set to the last one
> directly is better.

Is it really useless?  Be more descriptive.

> -	if (remote->url_nr > 0) {
> -		int i;
> -
> -		for (i = 0; i < remote->url_nr; i++)
> -			string_list_append(remote->name, list)->util = (void *)remote->url[i];
> -	} else
> -		string_list_append(remote->name, list)->util = NULL;
> +	string_list_append(remote->name, list)->util =
> +		remote->url_nr > 0
> +		? (void *)remote->url[remote->url_nr-1] : NULL;

When you have more than one URL associated with the remote (this makes
sense only for pushing), the current code adds that many string_list_item
to the list, each holding the URL.  "git remote -v" shows all of them.

Your change instead creates only one string_list_item and hold the last
URL.  Doesn't it make show_all() to show only one URL for the remote?