From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 10 Dec 2008 08:27:14 GMT
Subject: Re: [PATCH] make sure packs to be replaced are closed beforehand
Message-ID: <7vabb43065.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <493F71B7.60804@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Nicolas Pitre schrieb:
>> Especially on Windows where an opened file cannot be replaced, make
>> sure pack-objects always close packs it is about to replace. Even on
>> non Windows systems, this could save potential bad results if ever
>> objects were to be read from the new pack file using offset from the old
>> index.
>> 
>> This should fix t5303 on Windows.
> ...
>> OK, here it is at last.  Please confirm it works on Windows before Junio 
>> merges it.
>
> I can confirm that this patch fixes t5303 on Windows (MinGW).

Thanks; it is a bit too late for tonight, but it will appear in tomorrow's
'master'.