From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 29 Jan 2009 01:16:30 GMT
Subject: Re: [PATCH/RFC v1 5/6] combine-diff.c: remove a call to fstat() inside show_patch_diff()
Message-ID: <7vab9akj2p.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7v63jznp58.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Kjetil Barvik <barvik@broadpark.no> writes:
>
>> Currently inside show_patch_diff() we have and fstat() call after an
>> ok lstat() call.  Since we before the call to fstat() have already
>> test for the link case with S_ISLNK() the fstat() can be removed.
>
> Good eyes.  Thanks.

Heh, I noticed you will update the commit log message, so I'll dequeue
this and wait for an update.