From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 18 Apr 2009 01:24:36 GMT
Subject: Re: [PATCH] Allow git-shell to be used as a ssh forced-command
Message-ID: <7vab6e21pn.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090417234859.GY898@eagain.net>

Tommi Virtanen <tv@eagain.net> writes:

> On Fri, Apr 17, 2009 at 04:40:54PM -0700, Junio C Hamano wrote:
>> How does this interact with a typical gitosis installation?  I think it
>> extracts bits from the ORIGINAL_COMMAND and formulates a sanitized command
>> line and then passes it to git-shell but I do not think it removes the
>> variable from the environment.
>
> Yup, not sanitizing. I could make that change easily, if you want, but
> there's plenty of installations out there already.
>
> I'd say add a git-shell flag that enables any magic behavior, don't
> just magically work differently based on that environment variable.

Good.  I see Mike too already realized that the patch is unacceptable in
the current form.