From: Junio C Hamano Date: Wed, 16 Sep 2009 23:19:27 GMT Subject: Re: [RFC/PATCH 0/2] Speed up fetch with large number of tags Message-ID: <7vab0uwk8w.fsf@alter.siamese.dyndns.org> In-Reply-To: <20090916230350.GC14660@spearce.org> "Shawn O. Pearce" writes: >> Also, you might not have noticed, but my illustration patch was merely >> using it as a hint to optimize, and if the last ref we saw was not X when >> it is turn to handle X^{}, it simply falled back to the original logic, >> iow, the patch never compromised the correctness. > > Oh, I missed that. JGit I think flat out panics and disconnects > if the remote does this to us. What is the incentive in supporting > a broken server with a slower client? There is none. I think the original logic, being written in shell, run grep in the output, and the C code we are seeing is a literal translation of that. In other words, I think it is simply a historical accident.