From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 14 Dec 2009 23:39:07 GMT
Subject: Re: [PATCH] help.autocorrect: do not run a command if the command given is junk
Message-ID: <7vaaxlcehw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200912142255.36949.j.sixt@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> On Montag, 14. Dezember 2009, Junio C Hamano wrote:
>> In the meantime, I think squashing the following in would help us keep the
>> two magic numbers in sync.
>
> I do not think that keeping the numbers in sync is necessary. For example, the 
> similarity requirement for commands that run automatically could be stricter 
> than for the list of suggestions. Then it would be possible that a unique 
> best candidate is not good enough to be run automatically; there would only 
> be a list of suggestions.

Well thought out.  Would you want to reroll a patch with two symbolic
constants then?