From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 24 Feb 2010 06:15:10 GMT
Subject: Re: [PATCH v5 06/11] rebase -i: invoke post-rewrite hook
Message-ID: <7vaauzcg7l.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87f20b987fa7a389e89f8931d553de7095d2bc86.1266885599.git.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

> +test_expect_success 'git rebase -i (unchanged)' '
> +	git reset --hard D &&
> +	clear_hook_input &&
> +	FAKE_LINES="1 2" test_must_fail git rebase -i --onto A B &&

This

> ...
> +test_expect_success 'git rebase -i (skip)' '
> +	git reset --hard D &&
> +	clear_hook_input &&
> +	FAKE_LINES="2" test_must_fail git rebase -i --onto A B &&

and this

> ...
> +test_expect_success 'git rebase -i (squash)' '
> +	git reset --hard D &&
> +	clear_hook_input &&
> +	FAKE_LINES="1 squash 2" test_must_fail git rebase -i --onto A B &&

and this need to be fixed to something like

	( FAKE_LINES=... &&
          export FAKE_LINES &&
          test_must_fail git ... ) &&

for Bourne-shell portability.  test_must_fail is a shell function and the
usual one-shot-assignment-to-export rule does not apply.