From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 14 Mar 2010 00:07:45 GMT
Subject: Re: [PATCH] git status: ignoring untracked files must apply to submodules too
Message-ID: <7vaaubzrxq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B9C1AEC.2070605@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

> First: When called from "git status" run_diff_files() calls
> wt_status_collect_changed_cb() for every file it considers changed, so

This reminds me of another thing, perhaps independent, perhaps related.
Why aren't we collecting the submodule status in wt_status_collect() to
begin with?  It examines the submodule status in wt_status_print(), but
that feels quite against the way how the whole "struct wt_status" was
designed to be used in the first place, I think.  Would restuctuing the
code that way make this easier to handle?