From: Junio C Hamano Date: Fri, 20 May 2011 03:06:20 GMT Subject: Re: [PATCH 3/3] receive-pack: eliminate duplicate .have refs Message-ID: <7vaaei5avn.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110519213446.GC29793@sigill.intra.peff.net> At first I thought you are going to insert the object names into a sorted list and handle dups while doing so, but it makes a lot more sense to append first and then sort at the end, and skip the dups while scanning, which is what you did. Looked sane; thanks.