From: Junio C Hamano Date: Tue, 21 Jun 2011 19:28:15 GMT Subject: Re: [PATCH 07/13] revert: Introduce struct to keep command-line options Message-ID: <7vaadb7zn4.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110621165854.GL15461@elie> Jonathan Nieder writes: > Ramkumar Ramachandra wrote: > ... > The struct leaves out the variable "me". A person might wonder why > the above rationale applies to the other variables but not that one. :) Good point. >> Unfortunately, parsing strategy-option violates a C89 rule: >> Initializers cannot refer to variables whose address is not known at >> compile time. > > Reading this, one is led to wonder: > ... > - is this a regression? Let me add one. - how does this patch work around that issue?