From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 17 Oct 2011 23:25:08 GMT
Subject: Re: [PATCH/RFC 3/2] Refactor Git::config_*
Message-ID: <7vaa8zjj57.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201110172347.42568.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> The problem was with duplicated _maybe_self(@_), which should be run only
> once.  t9700-perl-git.sh passed because it uses only (recommended) object
> form, and not procedural form like git-svn.

Thanks.

I have a suspicion that a more standard implementation of _maybe_self()
would instead unshift a dummy singleton Git() instance instead of undef to
lift such a limitation, but perhaps the code relies on undef'ness of self
when called as a vanilla subroutine.