From: Junio C Hamano Date: Thu, 20 Oct 2011 18:55:17 GMT Subject: Re: [PATCH 3/6] revert: fix buffer overflow in insn sheet parser Message-ID: <7vaa8va3xm.fsf@alter.siamese.dyndns.org> In-Reply-To: <20111020180533.GA5563@elie.hsd1.il.comcast.net> Jonathan Nieder writes: > Incidentally, Ram might wonder why I fuss so much about commit > messages. It's actually very simple --- I think of them as part of > the code. And another reason is because I do fuss about them too ;-) It is easy to tell a good patch from a bad one by just reading the message without actually reading the patch text itself. When the log message justifies the cause and the approach in the right way, the actual patch becomes self evident. Also I often find myself coming up with a _better_ solution than the patch I originally prepared while writing the commit log message to explain it, and redoing the patch text to match the description.