From: Junio C Hamano Date: Wed, 04 Jan 2012 22:15:10 GMT Subject: Re: [PATCH 1/2] daemon: add tests Message-ID: <7vaa63p11t.fsf@alter.siamese.dyndns.org> In-Reply-To: <20120104204017.GC27567@ecki.lan> Clemens Buchacher writes: > On Wed, Jan 04, 2012 at 10:00:07AM -0800, Junio C Hamano wrote: >> >> >> >> + # kill git-daemon child of git >> >> >> + say >&3 "Stopping git daemon ..." >> >> >> + pkill -P "$DAEMON_PID" >> >> >> >> How portable is this one (I usually do not trust use of pkill anywhere)? >> > >> > I read that it is supposed to be more portable than skill or killall. >> > But I have no way to research this. I have implemented a workaround >> > using only 'ps' and 'kill' in [PATCH 3/6] avoid use of pkill. >> >> Yuck, that patch looks even uglier X-<. >> >> Do you really need to kill the children but not the daemon? > > If I kill just the parent "git daemon" command, then the actual > git-daemon (started by run_command) will be left behind. Sounds like we would be better off with a new "--foreground" option other daemon-ish projects seem to have?