From: Junio C Hamano Date: Mon, 05 Mar 2012 20:08:11 GMT Subject: Re: [PATCH 1/2] Allow Overriding GIT_BUILD_DIR Message-ID: <7vaa3u24lw.fsf@alter.siamese.dyndns.org> In-Reply-To: dag@cray.com (David A. Greene) writes: > Junio C Hamano writes: > >> Both of your changes seem to have broken indentation to use 8-SP at >> the beginning of some (but not all) lines instead 1-HT. I'll queue >> a fixed up version and push the result out in 'pu' later, so please >> double check to make sure I didn't screw up. > > Right. This is because you flagged an indentation issue with the > previous version of the patch. I think what happened is that the > previous version included the 1-HT (what is HT - half-tab?) spacing but > it "looked funny" with the additional "+" from the diff line. No, with your earlier patch, all the existing lines used horizontal tabs for indenting, and the line you added used runs of spaces. When such a hunk is shown in diff output, "+" will make it obvious that only the new line you added is wrong (because the initial "+" and " " is absorbed in the first horizontal tab for Tab-indented lines) and that is how I noticed and pointed out "a funny indentation" to you.