From: Junio C Hamano Date: Tue, 12 Feb 2013 18:55:05 GMT Subject: Re: [PATCHv4 3/6] Git.pm: refactor command_close_bidi_pipe to use _cmd_close Message-ID: <7va9r9gy5y.fsf@alter.siamese.dyndns.org> In-Reply-To: Michal Nazarewicz writes: > From: Michal Nazarewicz > > The body of the loop in command_close_bidi_pipe function is identical to > what _cmd_close function does so instead of duplicating, refactor change > _cmd_close so that it accepts list of file handlers to be closed, which s/file handlers/file handles/, I think.