From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 25 Feb 2013 19:37:51 GMT
Subject: Re: [PATCH 1/1] Fix date checking in case if time was not initialized.
Message-ID: <7va9qsxjzk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAHXAxrOjSS5jGLcCw4KTxP_F_uRQhi0cPSvzbx58jx9dP25XPA@mail.gmail.com>

Mike Gorchak <mike.gorchak.qnx@gmail.com> writes:

> 	if (tm->tm_hour < 0 || tm->tm_min < 0 || tm->tm_sec < 0)
> 		return -1;
>
> So is_date() always return negative result for the text string where
> date is placed before time like '2008-02-14 20:30:45'.

Yes, it returns this -1 on other platforms, but...

> It must fail on
> other platforms as well.

... the input '2008-02-14 20:30:45' still parses fine for others
(including me).  That is what is puzzling.

A shot in the dark: perhaps your time_t is unsigned?