From: Junio C Hamano Date: Fri, 05 Jul 2013 18:38:30 GMT Subject: Re: [PATCH v10 3/5] t4205, t6006, t7102: make functions better readable Message-ID: <7va9m07syh.fsf@alter.siamese.dyndns.org> In-Reply-To: <77116508da1bf88e6035cbd657c401cf96b08cbb.1373024281.git.Alex.Crezoff@gmail.com> Alexey Shumkin writes: > - msg=$(printf "modify 2nd file (ge\303\244ndert)") > + msg="modify 2nd file (ge\303\244ndert)" > if test -n "$1" > then > - msg=$(echo $msg | iconv -f utf-8 -t $1) > + print "$msg" | iconv -f utf-8 -t "$1" > + else > + print "$msg" > fi > - echo $msg > } I think I'll do s/print/&f/ before queuing this. Thanks.