From: Junio C Hamano <junkio@cox.net>
Date: Thu, 20 Oct 2005 04:16:14 GMT
Subject: Re: [PATCH] Do not send "want" lines for complete objects
Message-ID: <7v8xwovn5d.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0510200559540.3394@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
>> > +		    ((o = parse_object(remote)) != NULL) &&
>> > +		    (o->flags & COMPLETE) &&
>
> I just realized that parse_object() always reads the file, then does a 
> lookup (which makes the above code work), and then parses the file. It 
> always does all of these steps, even if the object was already parsed. Any 
> reason for this?

You are right.  We should be using lookup_object() for this part
of the code.