From: Junio C Hamano <junkio@cox.net>
Date: Thu, 17 Nov 2005 23:56:51 GMT
Subject: Re: [PATCH 1/5] Library code for user-relative paths, take three.
Message-ID: <7v8xvmsu9o.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051117193714.2B8995BF93@nox.op5.se>

exon@op5.se (Andreas Ericsson) writes:

> +	if(strict && *dir != '/')

(style everywhere)

	if (strict ...

> +	/* This is perfectly safe, and people tend to think of the directory
> +	 * where they ran git-init-db as their repository, so humour them. */
> +	(void)chdir(".git");

It might be safe, but I think it changes the behaviour of
upload-pack with strict case.  My gut reaction is we would want
"if (!strict)" in front.  Thoughts?