From: Junio C Hamano <junkio@cox.net>
Date: Wed, 07 Jun 2006 18:47:03 GMT
Subject: Re: [PATCH] Off-by-one error in get_path_prefix(), found by Valgrind
Message-ID: <7v8xo8hkgo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1149705204.11931.3.camel@dv>

Pavel Roskin <proski@gnu.org> writes:

> On Wed, 2006-06-07 at 20:05 +0200, Rene Scharfe wrote:
>> Argh, yes.  Thanks, Pavel!
>
> Actually, thanks to Julian Seward for Valgrind.
>
>>   However, the other branch is incorrect, too:
>> accessing path->buf[path->len] is wrong, even if it's within the buffer.
>> In order to use a length variable to point to the end of some string we
>> need to subtract 1. *sigh*  So, how about this one instead?
>
> Fine with me.  Thank you for noticing!

Thanks both.  Applied.