From: Junio C Hamano Date: Wed, 14 Feb 2007 05:16:57 GMT Subject: Re: mingw, windows, crlf/lf, and git Message-ID: <7v8xf1uxme.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Linus Torvalds writes: > NOTE NOTE NOTE! The "is_binary()" heuristics are totally made-up by yours > truly. I will not guarantee that they work at all reasonable. Caveat > emptor. But it _is_ simple, and it _is_ safe, since it's all off by > default. It might be safe for some definition of safe, but it is very Asian unfriendly. I'd probably suggest replacing it with what GNU diff uses, which we stolen and implemented in diff.c::mmfile_is_binary().