From: Junio C Hamano Date: Wed, 09 May 2007 05:03:30 GMT Subject: Re: [PATCH] Add pack.depth option to git-pack-objects and change default depth to 50 Message-ID: <7v8xbyzizh.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Nicolas Pitre writes: > On Tue, 8 May 2007, Theodore Tso wrote: > >> On Tue, May 08, 2007 at 11:38:46AM -0400, Nicolas Pitre wrote: >> > On Tue, 8 May 2007, Theodore Ts'o wrote: >> > >> > > Signed-off-by: "Theodore Ts'o" >> > >> > I'd prefer if tests were performed on the performance impact before >> > changing the default depth. If done separately from this patch then the >> > commit log could contain those results as well. >> >> The following results are on a recent git repository, using time to >> record the real, user, and sys times on the two commands: "git-gc >> --no-reuse-delta --window=X --depth=Y" and "git log --pretty=oneline >> -S'object' > /dev/null". All of these tests were done with a hot >> cache, so disk speed didn't enter into the calculations. > [...] >> My conclusion given this quick benchmark is that it seems to me that >> changing the defaults of --depth to 50, and keeping --window at 10, is >> a reasonable thing to do. > > Effectively. > > I'd still prefer to see the default changed in a patch of its own > though. I'll split the patch into two and apply them separately.