From: Junio C Hamano Date: Thu, 12 Jul 2007 00:03:23 GMT Subject: Re: [PATCH 1/2] Function stripspace now gets a buffer instead file descriptors. Message-ID: <7v8x9m1oac.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <1b46aba20707111641y615ff82dpf2da4afab2b17d58@mail.gmail.com> "Carlos Rica" writes: > Now the function cleanup is not removing spaces at all, but only > counting where the line of text ends. > > Before, in the previous version, the function cleanup was taking a > string as argument, and then it needed to modify that string. Now, it > just returns the new length, "not counting" the spaces and newline at > the end of the buffer passed. Its name and comments then could be > different, but I didn't know which ones. Ah, you are right. I misread the patch --- cleanup() does not even touch the buffer.