From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 04 Nov 2007 22:58:13 GMT
Subject: Re: [PATCH 01/10] Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts.
Message-ID: <7v8x5dsjne.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1194172262-1563-2-git-send-email-madcoder@debian.org>

Two comments.

 * I have updated 1/10 with typo and indentation fixes.

 * I see you changed 2/10 to use OPTIONS_KEEPDASHDASH instead of
   PARSEOPT_OPTS, but the scripts that do not want the --keep
   behaviour do not set OPTIONS_KEEPDASHDASH to empty, so I do
   not see how this updatet would make _any_ difference.  The
   user can still screw up by having OPTIONS_KEEPDASHDASH in
   their environments by mistake, curiosity or just plain
   stupidity.