From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Dec 2007 19:15:40 GMT
Subject: Re: [PATCH 2/2] xdi_diff: trim common trailing lines
Message-ID: <7v8x3xrstf.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071214090614.GB15610@xp.machine.xx>

Peter Baumann <waste.manager@gmx.de> writes:

> So you are loosing some values in your trim_common_tail function by
> making ctx only an int. (Not sure that it matters, but I noticed it
> while glancing over your code).

While it is true that this does not matter in practice (because the
context value initially comes from the end user via -U parameter that is
stored in a field of type int in diff_options structure), I agre that it
is the right thing to do to use the same type as underlying xdiff
library uses at the interface level.  From the layering point of view.
xdiff-interface.[ch] are meant to be a thin usability wrapper, it should
not needlessly deviate from how the underlying xdiff operates.