From: Junio C Hamano <junio@pobox.com>
Date: Wed, 21 May 2008 18:08:32 GMT
Subject: Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
Message-ID: <7v8wy34jj3.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0805161403130.30431@racer>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> The function fgets() has a big problem with NUL characters: it reads
> them, but nobody will know if the NUL comes from the file stream, or
> was appended at the end of the line.
>
> So implement a custom read_line() function.

Looking at what handle_body() does for TE_BASE64 and TE_QP cases, I have
to wonder if this is enough.  The loop seems to stop at (*op == NUL) which
follows an old assumption that each line is terminated with NUL, not the
new assumption you introduced that each line's length is kept in local
variable len.