From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 23 Jul 2008 00:09:51 GMT
Subject: Re: [PATCH] git-filter-branch.sh: Allow running in bare repositories
Message-ID: <7v8wvtjwa8.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080722233652.GT10151@machine.or.cz>

Petr Baudis <pasky@suse.cz> writes:

>   um, oops. I actually never got to know these by heart since I learnt
> to expliciply group the expressions early on. I guess my only excuse is
> that I've stumbled at 0bdf93cbf earlier and understood it the _wrong_
> way around since I'm getting really sleepy. ;-)
>
>   I still think my change improves the code readibility so it could be
> kept, but I'm fairly neutral on this.

I cannot be neutral when a patch introduces unnecessary fork.

The quality of shell scripts in git.git seems to have deteriorated over
time but I do not think we would want to spend too much maintainer time to
go back and fix all of them.  Please don't make things worse, at least.