From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 05 Aug 2008 00:54:14 GMT
Subject: Re: Not going beyond symbolic links
Message-ID: <7v8wvc2seh.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.1.10.0808041719380.3299@nehalem.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Mon, 4 Aug 2008, Junio C Hamano wrote:
>> 
>> I started to revisit this issue and patched "git update-index --add"
>> and "git add" so far.  Patches follow.
>
> Patches look good to me, but did you check the performance impact?
>
> The rewritten 'has_symlink_leading_path()' should do ok, but it migth 
> still be a huge performance downside to check all the paths for things 
> like "git add -u".

Not yet.

I think this is a necessary "correctness" thing to do regardless of the
performance impact, and adding the logic to stop at submodule boundary
(aka gitlinks) should come before optimization.