From: Junio C Hamano Date: Thu, 19 Mar 2009 23:00:09 GMT Subject: Re: [PATCH 00/11] Test on Windows - prequel Message-ID: <7v8wn16ruu.fsf@gitster.siamese.dyndns.org> In-Reply-To: <200903192158.46680.j6t@kdbg.org> Johannes Sixt writes: > On Mittwoch, 18. März 2009, Johannes Sixt wrote: >> I'm preparing a series of patches that adjust the test suite so that it >> passes on Windows (MinGW port). This is the initial part of it. Another >> dozen or more are to follow. By splitting the series I hope to get >> earlier feedback. >> >> The series is also available from >> >> git://repo.or.cz/git/mingw/j6t.git for-junio >> > I've updated the series. Would you please pick up it up from the URL > above? I think you have a typo in the "Use 'say'" one ("In on case"). Here is a diff from what I queued previously but didn't have a chance to merge to 'pu': test suite: Use 'say' to say something instead of 'test_expect_success' - Some test scripts report that some tests will be skipped. They used + Some tests report that some tests will be skipped. They used 'test_expect_success' with a trivially successful test. Nowadays we have the helper function 'say' for this purpose. - t9700-perl-git.sh was using 'say_color' for this kind of reporting; change - it to a vanilla 'say' for consistency. + In on case, 'say_color skip' is replaced by 'say' because the former is + not intended as a public API. Signed-off-by: Johannes Sixt - Signed-off-by: Junio C Hamano Other than that, the interdiff matches what I expected to see. Thanks.