From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Jun 2009 23:30:31 GMT
Subject: Re: [PATCHv3 1/4] parse-remote: function to get the tracking branch to be merge
Message-ID: <7v8wk2wbfs.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1244451651-22651-2-git-send-email-santi@agolina.net>

Santi Béjar <santi@agolina.net> writes:

> The only user of get_remote_refs_for_fetch was "git pull --rebase" and
> it only wanted the tracking branch to be merge. So, add a simple
> function with this new meaning.
>
> No behavior changes.

I am all for code reduction, but after following the original logic that
uses remote_refs_for_fetch (which knows about things like "git pull there
+refs/heads/master:refs/heads/origin tag v1.6.0" from the command line)
that in turn calls canon_refs_list_for_fetch (which returns a list e.g.
+refs/heads/master:refs/heads/origin refs/tags/v1.6.0:refs/tags/v1.6.0),
and do not quite see how you can casually say "No behaviour changes."