From: Junio C Hamano Date: Fri, 24 Jul 2009 05:13:43 GMT Subject: Re: [PATCH 2/2] git repack: keep commits hidden by a graft Message-ID: <7v8wievf20.fsf@alter.siamese.dyndns.org> In-Reply-To: <34dfd22bb99c7c466b6131876e8b52ac46f388aa.1248362827u.git.johannes.schindelin@gmx.de> Johannes Schindelin writes: > diff --git a/commit.c b/commit.c > index a47fb4d..ef8e911 100644 > --- a/commit.c > +++ b/commit.c > @@ -262,7 +262,7 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size) > bufptr[47] != '\n') > return error("bad parents in commit %s", sha1_to_hex(item->object.sha1)); > bufptr += 48; > - if (graft) > + if (graft && (graft->nr_parent < 0 || grafts_replace_parents)) > continue; Hmm, what is this "if it is negative" check for? I did not see it mentioned in the proposed commit log message.