From: Junio C Hamano Date: Tue, 01 Dec 2009 17:20:22 GMT Subject: Re: [PATCH] get_ref_states: strdup entries and free util in stale list Message-ID: <7v8wdm1ui1.fsf@alter.siamese.dyndns.org> In-Reply-To: <36ca99e90912010132iee0d42fo933aeb12833ad1ad@mail.gmail.com> Bert Wesarg writes: >>  - The ref abbrev_branch() is called and the address of whose substring is >>   taken to be used as "name" in handle_one_branch() is refspec.src, but >>   what goes to .util is refname that is refspec.dst---they are different >>   strings and one is not a substring of the other. > I don't see you point here. Of course you don't ;-) because we were looking at different versions. I wanted to apply the same fix to both maint and master. For the code in 'master' your observation is 100% correct.