From: Junio C Hamano Date: Sat, 20 Mar 2010 20:12:34 GMT Subject: Re: [PATCH] Add a git-completion rpm subpackage to the spec Message-ID: <7v8w9mda6l.fsf@alter.siamese.dyndns.org> In-Reply-To: <1269109086-8887-1-git-send-email-bwalton@artsci.utoronto.ca> Ben Walton writes: > Make the rpm spec file create a git-completion subpackage that > contains the bash completion support from the contrib/ directory. > > Signed-off-by: Ben Walton > --- > > This is the alternate method for shipping the bash completion support. > I think I personally prefer this method, but I'd be happy to see > either solution ship as part of the .spec file so that I don't need to > continue handling it separately. As long as %{_sysconfdir}/bash_completion.d/ is the appropriate place for *all* RPM based distros, which I don't knonw, the patch looks sensible. May I ask for what distribution you are "handling it"? The last thing I want to do is to get in the way of distro packagers. I looked for "gitcompletion" or "git-completion" in rpmfind.net, but didn't find anything, which may actually be a good sign that whatever we do here won't stomp on whatever distro package maintainers would do.