From: Junio C Hamano Date: Thu, 12 Aug 2010 22:44:20 GMT Subject: Re: [PATCH 04/10] Add treap implementation Message-ID: <7v8w4bpi2j.fsf@alter.siamese.dyndns.org> In-Reply-To: <20100812221115.GJ2029@burratino> Jonathan Nieder writes: > diff --git a/diffcore.h b/diffcore.h > index fed9b15..05ebc11 100644 > --- a/diffcore.h > +++ b/diffcore.h > @@ -98,7 +98,7 @@ struct diff_queue_struct { > (q)->queue = NULL; \ > (q)->nr = (q)->alloc = 0; \ > (q)->run = 0; \ > - } while(0); > + } while (0) This is a _bad_ one. Thanks.