From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 13 Aug 2010 01:22:19 GMT
Subject: Re: [RFC/PATCHv2] fetch: allow command line --tags to override config
Message-ID: <7v8w4bmhmc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1281567440-6329-1-git-send-email-ComputerDruid@gmail.com>

Daniel Johnson <computerdruid@gmail.com> writes:

> Originally, if remote.<name>.tagopt was set, the --tags and option would
> have no effect when given to git fetch. So if
> tagopt="--no-tags"
>
> 	git fetch --tags
>
> would not actually fetch tags.
>
> This patch changes this behavior to only follow what is written in the
> config if there is no option passed by the command line.
>
> Signed-off-by: Daniel Johnson <ComputerDruid@gmail.com>
> ---
> On Sat, Aug 7, 2010 at 10:17 PM, Tay Ray Chuan <rctay89@gmail.com> wrote:
>> On Fri, Aug 6, 2010 at 9:54 PM, Daniel Johnson <computerdruid@gmail.com> wrote:
>>> ---
>>> How does this look?
>>
>> Looks ok - now you'll have to squash this with your code patch.
> And here it is. Sorry about the lateness. I also fixed a mistake I made in the
> documentation (linked to the wrong secton).
>
> I'd still like comments on both the code and the change in behavior behind it.

The current behaviour seems to me a bug introduced while git-fetch was
rewritten in C (the original found in contrib/examples reads from the
config only when no --tags/--no-tags option is given from the command
line).

Is this something we can protect with a test script from future breakages?

Thanks.