From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 17 Mar 2011 20:55:17 GMT
Subject: Re: [PATCH 1/2] gitweb: fix #patchNN anchors when path_info is enabled
Message-ID: <7v8vwd31sa.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201103172020.05055.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

>>> or even make it so 'href(-anchor=>"ANCHOR")' implies '-replay => 1'.
>> 
>> I don't see why "or even" is an improvement, given the following
>> implementation.
>
> Well, 
>
>   -href => href(-anchor=>"patch$patchno")
>
> is closer in spirit to
>
>   -href => "#patch$patchno"
>
> that is currently used, and does not work with path_info.

I questioned "implies '-replay => 1'" part, not the use of href(...) part.