From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 Dec 2011 18:12:06 GMT
Subject: Re: [PATCH 1/3] Make commit_tree() take message length in addition to the commit message
Message-ID: <7v8vmfqayx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1323871699-8839-2-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

Justification?

As all 3 primary users of this API feed strbuf.buf to the function, it
would make more sense to change the first parameter to a pointer to a
strbuf, no?