From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 10 Jun 2012 06:37:58 GMT
Subject: Re: [PATCH] gitk: add support for -G'regex' pickaxe variant
Message-ID: <7v8vfvbrjt.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4FD31476.90104@in.waw.pl>

Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:

> On 06/08/2012 04:32 AM, Martin Langhoff wrote:
>> git log -G'regex' is a very usable alternative to the classic
>> pickaxe. Minimal patch to make it usable from gitk.
>
>>      set gm [makedroplist .tf.lbar.gdttype gdttype \
>>  		[mc "containing:"] \
>>  		[mc "touching paths:"] \
>> -		[mc "adding/removing string:"]]
>> +		[mc "adding/removing string:"] \
>> +		[mc "changes match regex:"]]
>
> Hi,
>
> this feature is definitely useful. One nitpick: the string that you add
> becomes part of a sentence in the GUI: "prev/next commit changes match
> regex", which is in different grammatical form then the existing
> snippets. Should be something with '-ing'.

"prev/next commit with changes matching regex" perhaps?

In any case, Paul needs to be in the loop when we discuss gitk
changes.