From: Junio C Hamano Date: Tue, 26 Jun 2012 17:47:32 GMT Subject: Re: [PATCH 1/5] git-remote-mediawiki: don't compute the diff when getting commit message Message-ID: <7v8vfac6dn.fsf@alter.siamese.dyndns.org> In-Reply-To: <1340726673-25496-2-git-send-email-Matthieu.Moy@imag.fr> Matthieu Moy writes: > --- Not signed off yet? > contrib/mw-to-git/git-remote-mediawiki | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki > index a34f53f..a8e6287 100755 > --- a/contrib/mw-to-git/git-remote-mediawiki > +++ b/contrib/mw-to-git/git-remote-mediawiki > @@ -874,8 +874,7 @@ sub mw_push_revision { Curious. The hunk replaces an old line with a new one, but somehow claims to reduce 8 to 7 by one??? > # TODO: for now, it's just a delete+add > my @diff_info_list = split(/\0/, $diff_infos); > # Keep the first line of the commit message as mediawiki comment for the revision > - my $commit_msg = (split(/\n/, run_git("show --pretty=format:\"%s\" $sha1_commit")))[0]; > + my $commit_msg = (split(/\n/, run_git("log -1 --format=\"%s\" $sha1_commit")))[0]; > chomp($commit_msg); > # Push every blob > while (@diff_info_list) {