From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 14 Aug 2012 04:56:57 GMT
Subject: Re: [PATCH 4/4] fetch-pack: mention server version with verbose output
Message-ID: <7v8vdiax5y.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120814020210.GB7891@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> +	if ((agent_feature = server_feature_value("agent", &agent_len))) {
>  		agent_supported = 1;
> +		if (args.verbose && agent_len) {
> +			fprintf(stderr, "Server version is %.*s\n",
> +				agent_len, agent_feature);
> +		}
> +	}

OK.  The one I queued in 'pu' said "Server version not disclosed"
when length was 0, but I think I like this one better.

Also I like the the update to the parsing code in the previous
patch.  It makes the logic clearer.

Thanks.