From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 18 Mar 2013 15:12:38 GMT
Subject: Re: [PATCH v2 4/4] pack-refs: add fully-peeled trait
Message-ID: <7v8v5kpwrd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <51468615.70503@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
>
> and ACK for the whole series, once Junio's points are addressed.
>
> Regarding Junio's readability suggestion: I agree that his versions are
> a bit more readable, albeit at the expense of having to evaluate a bit
> more logic for each reference rather than just once when the header line
> is handled.  So I don't have a preference either way.

The way the conditional is written, in the longer term we
will almost always compare "peeled == PEELED_FULLY", and otherwise
we will do the same !prefixcmp(refs/tags/), so I do not think there
is "more logic" that matters compared to the original.

Thanks, both; will replace what was queued with "SQUASH???".