From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 25 Mar 2013 15:54:42 GMT
Subject: Re: [PATCH v2 1/4] Move commit GPG signature verification to commit.c
Message-ID: <7v8v5b1nlp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <514D0C15.9000100@physik.tu-berlin.de>

Sebastian Götte <jaseg@physik.tu-berlin.de> writes:

> Signed-off-by: Sebastian Götte <jaseg@physik-pool.tu-berlin.de>
> ---
>  commit.c        | 54 ++++++++++++++++++++++++++++++++++++++++++++++
>  commit.h        |  9 ++++++++
>  gpg-interface.h |  6 ++++++
>  pretty.c        | 67 +++++----------------------------------------------------
>  4 files changed, 74 insertions(+), 62 deletions(-)
>
> diff --git a/commit.c b/commit.c
> index e8eb0ae..d0d9135 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -1023,6 +1023,60 @@ free_return:
>  	free(buf);
>  }
>  
> +static struct {
> +	char result;
> +	const char *check;
> +} signature_check[] = {
> +	{ 'G', ": Good signature from " },
> +	{ 'B', ": BAD signature from " },
> +};

This seems to be based on the old codebase.  4a868fd655a7 (pretty:
parse the gpg status lines rather than the output, 2013-02-14) is
already in 'master' for this cycle, and it is likely that we would
want to have the same fix for 1.8.1.x maintenance track as well.