From: Junio C Hamano Date: Wed, 29 May 2013 17:14:45 GMT Subject: Re: [PATCH 2/4] remote-helpers: rename tests Message-ID: <7v8v2xvhbu.fsf@alter.siamese.dyndns.org> In-Reply-To: <51a56ce142986_807b33e18100084@nysa.mail> Felipe Contreras writes: >> I do not see how it makes sense to copy how they deviate from us >> back to our codebase, especially if we plan to eventually move some >> of these tests out of contrib/ area, but even without such a plan in >> the future. > > They deviate from us, we deviate from them, whatever. We are a single project, > what more than one project does is more standard. We are a single project, so it is better to consistently follow the local convention established here. If your proposal were to - Convert t/*.sh to end with .t intead, to change the project convention, and - Make contrib/ things also conform to that new convention. it may make some sense to discuss the pros and cons of such a move, but changing only contrib/ has no effect other than making it even less consistent with the rest of the project.