From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 12 Jun 2013 17:27:53 GMT
Subject: Re: [PATCH 1/3] finish_copy_notes_for_rewrite(): Let caller provide commit message
Message-ID: <7v8v2f5jdy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1370995981-1553-2-git-send-email-johan@herland.net>

Johan Herland <johan@herland.net> writes:

> When copying notes for a rewritten object, the resulting notes commit
> would have the following hardcoded commit message:
>
>   Notes added by 'git notes copy'
>
> This is obviously bogus when the notes rewriting is performed by
> 'git commit --amend'.
>
> Therefore, let the caller specify an appropriate notes commit message
> instead of hardcoding it. The above message is used for 'git notes copy',
> but when calling finish_copy_notes_for_rewrite() from builtin/commit.c,
> we use the following message instead:
>
>   Notes added by 'git commit --amend'
>
> Cc: Thomas Rast <trast@inf.ethz.ch>
> Signed-off-by: Johan Herland <johan@herland.net>

Makes sense.  Thanks.