From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 25 Mar 2014 04:56:55 GMT
Subject: Re: [PATCH 03/12] t: drop useless sane_unset GIT_* calls
Message-ID: <7v8uryq3jc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20140324215638.GH13728@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> Hmph.  I am looking at "git show HEAD^:t/t0001-init.sh" after
>> applying this patch, and it does look consistently done with
>> GIT_CONFIG and GIT_DIR (I am not sure about GIT_WORK_TREE but from a
>> cursory read it is done consistently for tests on non-bare
>> repositories).
>
> I don't understand why we stop bothering with the unsets starting with
> "init with --template". Are those variables not important to the outcome
> of that and later tests, or did the author simply not bother because
> they are noops?

If I had to guess (without running "blame", so it may well turn out
that "the author" may turn out to be me ;-), it is simply the author
not being careful.